Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import CefSharp.Wpf.HwndHost into main repository. #4981

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Import CefSharp.Wpf.HwndHost into main repository. #4981

wants to merge 3 commits into from

Conversation

amaitland
Copy link
Member

@amaitland amaitland commented Nov 16, 2024 •
edited
Loading

Fixes: [issue-number]
#4982

Summary:

  • Import the CefSharp.Wpf.HwndHost code into a subfolder in the CefSharp.Wpf project

Changes:

  • Import code into HwndHost folder (namespace in CefSharp.Wpf project)
  • Add new common interface
  • Add the existing example (though will be migrated to MinimalExample shortly)

How Has This Been Tested?

  • Manual currently (We can add a test into the Test project)

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Updated documentation

Checklist:

  • Tested the code(if applicable)
  • Commented my code
  • Changed the documentation(if applicable)
  • New files have a license disclaimer
  • The formatting is consistent with the project (project supports .editorconfig)

@amaitland amaitland linked an issue Nov 16, 2024 that may be closed by this pull request
Feature Request - Migrade HwndHost code into main repository #4982
Open
@amaitland
Copy link
Member Author

Still a few thing to resolve

  • Meta nuget package
  • Add some tests now the project is in the main repo
  • Update the example to be part of the Wpf example so it can used the existing tabbed interface
  • Remove the current Example.

@AppVeyorBot
Copy link

❌ Build CefSharp 130.1.90-CI5096 failed (commit ae53ed4b50 by @amaitland)

@mitchcapper mitchcapper mentioned this pull request Nov 17, 2024
Open
1 task
@amaitland
Copy link
Member Author

I was hoping to have this done for M131, feels a bit too rushed, so will wait for M132

@amaitland
Copy link
Member Author

Need to manually cherry pick changes from PR cefsharp/CefSharp.Wpf.HwndHost#31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request - Migrade HwndHost code into main repository
2 participants
@amaitland @AppVeyorBot